fix(vanish): correct VanishStatusChangeEvent argument order to prevent NPE from console#6497
Closed
Touchie771 wants to merge 1 commit intoEssentialsX:2.xfrom
Closed
fix(vanish): correct VanishStatusChangeEvent argument order to prevent NPE from console#6497Touchie771 wants to merge 1 commit intoEssentialsX:2.xfrom
Touchie771 wants to merge 1 commit intoEssentialsX:2.xfrom
Conversation
Member
|
Changing the parameter order will silently break all existing plugins that read these parameters swapped. I believe |
Member
|
Succeeded by #6510 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #6388.
Details
Proposed fix:
Swap the arguments so affected = user (the vanish target, never null) and controller = sender (null when console, which is valid and expected by the API).
Additionally, a defensive null guard is added to BukkitListener.onVanishStatusChange() to prevent crashes from any third-party plugin that fires VanishStatusChangeEvent with a null affected user.
Environments tested:
OS: Linux
Java version: 21
CraftBukkit/Spigot/Paper 1.12.2CraftBukkit 1.8.8